Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[REVERTED] [Android] fix android scrollbar visibility issue #8090

Merged
merged 1 commit into from Oct 23, 2019
Merged

[REVERTED] [Android] fix android scrollbar visibility issue #8090

merged 1 commit into from Oct 23, 2019

Conversation

ravinderjangra
Copy link
Contributor

@ravinderjangra ravinderjangra commented Oct 18, 2019 •
edited by samhouts

Description of Change

fixed Android scrollview scrollbar visibility issue.

Issues Resolved

Platforms Affected

  • Android

Before/After Screenshots

Before
before

After
after scrollbar

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in v4.4.0 Oct 18, 2019
@PureWeen
Copy link
Contributor

PureWeen commented Oct 22, 2019 •
edited

@DineshBabuYadav Will this change work ok with SyncFusion?

I tested the code change against the repo here https://github.com/SyncfusionExamples/ListView-GettingStarted-in-Xamarin-Forms and didn't see any issues

I noticed one part inside ExtendedScrollViewRenderer where it accesses the Context so just wanted to verify

I've attached the nuget if you would like to test
ScrollViewContextWrap.zip

@rmarinho rmarinho merged commit b5ade76 into xamarin:master Oct 23, 2019
v4.4.0 automation moved this from In Review to Done Oct 23, 2019
@rmarinho
Copy link
Member

We merged this but it's failing tests on API19, investigating.

@rmarinho rmarinho mentioned this pull request Oct 24, 2019
Merged
2 tasks
@samhouts samhouts added this to the 4.4.0 milestone Oct 31, 2019
@PureWeen PureWeen mentioned this pull request Nov 5, 2019
Closed
CliffAgius pushed a commit to CliffAgius/Xamarin.Forms that referenced this pull request Dec 6, 2019
@ravinderjangra @CliffAgius
Fix android scrollbar visibility issue (xamarin#8090) fixes xamarin#7629
c6b5e5b 
 xamarin#8015
@dminta dminta mentioned this pull request Jan 7, 2020
Closed
@ravinderjangra ravinderjangra deleted the scrollbar-fix branch January 31, 2020 11:13
@stephanpalmer stephanpalmer mentioned this pull request Feb 17, 2020
Closed
@CARP-Kaiser
Copy link

@samhouts I am encountering this issue using the android emulator api version 28 and xamarin forms 4.5.0.356.

@samhouts
Copy link
Member

@CARP-Kaiser Can you please open a new issue? Thanks!

@velocitysystems
Copy link
Contributor

@samhouts This PR needs to be reversed given the visual issues it has introduced. Could this change please be reversed until it can be correctly implemented without affecting child controls such as Label and Entry?

This was referenced Apr 24, 2020
Merged
Closed
@samhouts samhouts changed the title [Android] fix android scrollbar visibility issue [REVERTED] [Android] fix android scrollbar visibility issue Apr 24, 2020
@ravinderjangra
Copy link
Contributor Author

Thanks @samhouts for reverting this. It seems my PR caused multiple regression issues. I'll try to see if I can find a better solution to the problem without causing any new issue.

samhouts pushed a commit that referenced this pull request Apr 27, 2020
@jfversluis
Revert #8090 Android scrollbar flashes (#10447)
bb6ea96 
fixes #9591
fixes #9423
fixes #9019
fixes #8986
@jsuarezruiz jsuarezruiz mentioned this pull request May 12, 2020
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

Assignees

@rmarinho rmarinho

@PureWeen PureWeen

Labels
hacktoberfest 🍻 p/Android reverted t/bug 🐛
Projects
No open projects
v4.4.0
  
Done
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ravinderjangra @PureWeen @rmarinho @CARP-Kaiser @samhouts @velocitysystems