Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Make sure all children are parented #831

Merged
merged 2 commits into from Mar 22, 2017
Merged

[C] Make sure all children are parented #831

merged 2 commits into from Mar 22, 2017

Conversation

@StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Mar 22, 2017

Description of Change

If Layout.InternalChildren are added in the base ctor, the event handler isn't connected yet, and the parenting code isn't executed.

So, all children added directly or indirectly through implicit styles (handled in base ctor) are orphans. This fix gives a foster parent to those children. They'll get as much love as natural borns, but they'll still be a bit different, and I have no code to fix that.

NOTE: this is a regression introduced by a fix for the previewer, and it needs to be backported to 2.3.4

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@samhouts samhouts merged commit 8cc9137 into master Mar 22, 2017
6 checks passed
6 checks passed
Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3751, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details
@samhouts samhouts deleted the fix-53381 branch Mar 22, 2017
rmarinho added a commit that referenced this pull request Mar 22, 2017
* unit test

* [C] make sure all children are properly parented
@samhouts samhouts added D15.4 and removed cla-not-required labels Oct 10, 2017
@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.