This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] Make sure all children are parented #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
Mar 22, 2017
samhouts
approved these changes
Mar 22, 2017
rmarinho
pushed a commit
that referenced
this pull request
Mar 22, 2017
* unit test * [C] make sure all children are properly parented
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If Layout.InternalChildren are added in the base
ctor, the event handler isn't connected yet, and the parenting code isn't executed.So, all children added directly or indirectly through implicit styles (handled in base ctor) are orphans. This fix gives a foster parent to those children. They'll get as much love as natural borns, but they'll still be a bit different, and I have no code to fix that.
NOTE: this is a regression introduced by a fix for the previewer, and it needs to be backported to 2.3.4
Bugs Fixed
API Changes
/
Behavioral Changes
/
PR Checklist