Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Spec] CSharpForMarkup #8342

Merged
merged 69 commits into from Feb 27, 2020
Merged

[Spec] CSharpForMarkup #8342

merged 69 commits into from Feb 27, 2020

Commits on Oct 31, 2019

  1. - Add MarkupExtensions from https://github.com/VincentH-Net/CSharpFor…

    …Markup/blob/061566282706de22d040e5b7b32bc3c2e3e323e3/src/XamarinFormsMarkupExtensions.cs
    
    - Remove specific converters
    - Fix .NETStandard 1 build errors by refactoring IConvertible to Enum generic constraints
    - Add RegisterDefaultBindableProperties method
    - Reformat source to comply with Forms contibuting guidelines
    VincentH-Net committed Oct 31, 2019
    Copy the full SHA
    7c71a9b View commit details
    Browse the repository at this point in the history
  2. - Move markup extensions to Xamarin.Forms.Markup namespace to prevent…

    … impact on existing code and to support clear separation of UI markup from UI logic
    
    - Split up source file for better maintainability
    VincentH-Net committed Oct 31, 2019
    Copy the full SHA
    910d0d5 View commit details
    Browse the repository at this point in the history
  3. Cleanup:

    - Names of generic types and variables to reflect where clauses
    - Namespaces remove unused & sort
    - Add whitespace
    - Remove unused file
    VincentH-Net committed Oct 31, 2019
    Copy the full SHA
    0925655 View commit details
    Browse the repository at this point in the history
  4. Fix for incorrect type name in exception message

    Remove RowCol helpers because compiler cannot infer its generic type parameters. Use Row and Col methods instead
    VincentH-Net committed Oct 31, 2019
    Copy the full SHA
    34cc74d View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    5fd551f View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    78eb510 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Copy the full SHA
    a7cbdd1 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    50ea9bb View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Merge branch 'master' of https://github.com/xamarin/Xamarin.Forms

    Vincent Hoogendoorn committed Jan 6, 2020
    Copy the full SHA
    fe96761 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Copy the full SHA
    82eaeaa View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    98914aa View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c76b388 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Copy the full SHA
    7a2d7fc View commit details
    Browse the repository at this point in the history
  2. .Font:

    - Support any IFontElement (was limited to Button, Label, Entry and Picker)
    - Fix for italic ignored when bold == true
    VincentH-Net committed Jan 9, 2020
    Copy the full SHA
    c0fd249 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    09e7bda View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    8960e25 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    09fb3bb View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Copy the full SHA
    ba8b91b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    1bdecd1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4760d76 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    ed48594 View commit details
    Browse the repository at this point in the history
  5. Add unit tests for ViewInFlexLayoutExtensions, ViewInGridExtensions a…

    …nd VisualElementExtensions
    VincentH-Net committed Jan 10, 2020
    Copy the full SHA
    864a03d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Merge branch 'master' of https://github.com/VincentH-Net/Xamarin.Forms

    Vincent Hoogendoorn committed Jan 13, 2020
    Copy the full SHA
    627a373 View commit details
    Browse the repository at this point in the history
  2. Add default bindable property for all applicable bindable objects in …

    …core.
    Vincent Hoogendoorn committed Jan 13, 2020
    Copy the full SHA
    b8bbc6a View commit details
    Browse the repository at this point in the history
  3. Add unit tests for DefaultBindableProperties

    Vincent Hoogendoorn committed Jan 13, 2020
    Copy the full SHA
    9363c9c View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Support Bind, Assign and Invoke on BindableObject (was Element)

    Add inline doc to clarify purpose of Bind overloads
    VincentH-Net committed Jan 14, 2020
    Copy the full SHA
    3397210 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    cd34f25 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Fix for attributes not set in .Font

    Rename fontSize parameter to size
    Enable .FontSize, .Bold and .Italic on IFontElement (was Label)
    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    38d5474 View commit details
    Browse the repository at this point in the history
  2. Add unit tests for ElementExtensions

    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    c29f372 View commit details
    Browse the repository at this point in the history
  3. Add unit tests for ElementExtensions

    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    6bb06bd View commit details
    Browse the repository at this point in the history
  4. Add assert of exception message content in GetDefaultBindableProperty…

    …ForUnsupportedType
    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    83cc7f7 View commit details
    Browse the repository at this point in the history
  5. Add unit tests for EnumsForGridRowsAndColumns

    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    0cf6c33 View commit details
    Browse the repository at this point in the history
  6. Add inline doc to clarify purpose of gesture recognizer binding overl…

    …oads
    
    Rename private constant bindingContextPropertyName to bindingContextPath for clarity
    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    8e4541a View commit details
    Browse the repository at this point in the history
  7. Add unit tests for Style; cleanup namespaces in Style

    Vincent Hoogendoorn committed Jan 15, 2020
    Copy the full SHA
    3c3741d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Copy the full SHA
    0bf8d98 View commit details
    Browse the repository at this point in the history
  2. Add IGestureRecognizers to GestureElement and View, to avoid code dup…

    …lication when accessing the existing GestureRecognizers property
    VincentH-Net committed Jan 21, 2020
    Copy the full SHA
    3c1178f View commit details
    Browse the repository at this point in the history
  3. - Add specific helpers for more built-in gesture recognizers

    - Add helpers to support initializing gesture recognizers
    - Eliminate duplicate code for View and GestureElement by using new IGestureRecognizers
    - Simplify implementation
    - Rename ViewGesturesExtensions to ElementGesturesExtensions
    VincentH-Net committed Jan 21, 2020
    Copy the full SHA
    94616fa View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    857ffe5 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    def91da View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    0d48c20 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Add support for typed converter parameters

    Add asserts for conversion values in unit tests
    VincentH-Net committed Jan 22, 2020
    Copy the full SHA
    96a424f View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d768bf2 View commit details
    Browse the repository at this point in the history
  3. Add missing calls to Bind overloads in unit test for supporting deriv…

    …ed types in BindableObject extensions fluent API
    VincentH-Net committed Jan 22, 2020
    Copy the full SHA
    516c378 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    57eec38 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    acc51d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Copy the full SHA
    ba13d3c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    00a622a View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c667ee4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Add BindCommand helper to bind to default Command + CommandParameter …

    …properties
    
    Add RegisterForCommand to register default Command + CommandParameter properties for custom bindable objects
    Vincent Hoogendoorn committed Jan 27, 2020
    Copy the full SHA
    4cf16f6 View commit details
    Browse the repository at this point in the history
  2. - Change Bind*Gesture helper parameters to match BindCommand paramete…

    …rs, to enable binding to Command + CommandParameter in a single compact call (removed parameters did not make sense for a command).
    
    - Add inline doc to more ElementGesturesExtensions helpers where needed
    - Improve ElementGesturesExtensions source formattting for consistency and readability
    Vincent Hoogendoorn committed Jan 27, 2020
    Copy the full SHA
    33fc35e View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. Remove PlatformSpecificsExtensions

    (only 2 iOS-only helpers; replace with guidance in PR description on how to use any platform specific with .Invoke)
    VincentH-Net committed Jan 28, 2020
    Copy the full SHA
    837dd68 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Copy the full SHA
    983a522 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    94dee30 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Copy the full SHA
    8be0536 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    32ba768 View commit details
    Browse the repository at this point in the history
  3. Change gesture recognizer helpers implementation from reuse existing …

    …instance to always add new instance
    VincentH-Net committed Feb 7, 2020
    Copy the full SHA
    5b9c3f5 View commit details
    Browse the repository at this point in the history
  4. Change Bind*Gesture helpers default to not bind the commandparameter …

    …(is the more common scenario)
    VincentH-Net committed Feb 7, 2020
    Copy the full SHA
    093d29e View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    9a3c1f6 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    8cd1249 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Rename helpers Left -> Start, Right -> End

    Add opt-in LeftToRight and RightToLeft helpers
    VincentH-Net committed Feb 11, 2020
    Copy the full SHA
    fe2a6a2 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6016e5b View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0b79331 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Add Markup_Experimental flag for all API methods and update all unit …

    …tests to run with and without the flag
    Vincent Hoogendoorn committed Feb 13, 2020
    Copy the full SHA
    9794fb9 View commit details
    Browse the repository at this point in the history
  2. Resolved merge conflict on ExperimentalFlags

    Vincent Hoogendoorn committed Feb 13, 2020
    Copy the full SHA
    85de383 View commit details
    Browse the repository at this point in the history
  3. Re-add "Markup_Experimental" flag

    Vincent Hoogendoorn committed Feb 13, 2020
    Copy the full SHA
    df6a192 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Copy the full SHA
    d33c1c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Copy the full SHA
    058a1c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Copy the full SHA
    9d62bda View commit details
    Browse the repository at this point in the history
  2. Add default bindable property for RadioButton - fixes test AllBindabl…

    …eElementsInCoreHaveDefaultBindablePropertyOrAreExcluded failure
    VincentH-Net committed Feb 20, 2020
    Copy the full SHA
    7189ecc View commit details
    Browse the repository at this point in the history