[C] Added ability to predefine value to prompt #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
requested changes
Nov 5, 2019
StephaneDelcroix
approved these changes
Nov 6, 2019
rmarinho
approved these changes
Nov 6, 2019
samhouts
added
the
approved
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Dec 1, 2019
…amarin#8346 * Added ability to predefine value * Prevent ABI break * Update Issue6713.cs
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Dec 1, 2019
…amarin#8346 * Added ability to predefine value * Prevent ABI break * Update Issue6713.cs
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allows you to add a predefined value to be set whenever a prompt is opened
Issues Resolved
API Changes
Changed:
Xamarin.Forms.Internals.PromptArguments(string title, string message, string accept = "OK", string cancel = "Cancel", string placeholder = null, int maxLength = -1, Keyboard keyboard = default(Keyboard), string initialValue = "")(addedinitialValue)Xamarin.Forms.Page.DisplayPromptAsync(string title, string message, string accept = "OK", string cancel = "Cancel", string placeholder = null, int maxLength = -1, Keyboard keyboard = default(Keyboard), string initialValue = "")(addedinitialValue)Deprecated:
Xamarin.Forms.Internals.PromptArguments(string title, string message, string accept = "OK", string cancel = "Cancel", string placeholder = null, int maxLength = -1, Keyboard keyboard = default(Keyboard))Xamarin.Forms.Page.DisplayPromptAsync(string title, string message, string accept = "OK", string cancel = "Cancel", string placeholder = null, int maxLength = -1, Keyboard keyboard = default(Keyboard))Platforms Affected
Behavioral/Visual Changes
Because of the default value in the parameter the string will still be empty on default. The user now has the ability to leverage the new parameter to prefill a value
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist