Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix 53427; Change default UAP styling for a label #837

Merged
merged 1 commit into from Mar 27, 2017
Merged

Conversation

kingces95
Copy link
Contributor

@kingces95 kingces95 commented Mar 23, 2017

Description of Change

Unexpected styling for UWP EntryCell label: https://bugzilla.xamarin.com/attachment.cgi?id=20400

The user expected the EntryCell label styling to match the SwitchCell label styling. EntryCell style is set here:

<TextBlock Text="{Binding Label}" Style="{ThemeResource BaseTextBlockStyle}" Foreground="{Binding LabelColor, Converter={StaticResource ColorConverter}, ConverterParameter=SystemControlBackgroundChromeMediumLowBrush}" />
.

As you can see it sets Foreground="{Binding LabelColor, Converter={StaticResource ColorConverter}, ConverterParameter=SystemControlBackgroundChromeMediumLowBrush}".

This must have been added to allow coloring the label (prob to red to indicate validation error) however no other controls allow coloring the label -- just EntryCell. Which is fine but there is no precedent for the ConverterParameter. Currently its value is SystemControlBackgroundChromeMediumLowBrush but I think it should be DefaultTextForegroundThemeBrush.

Bugs Fixed

Bug https://bugzilla.xamarin.com/show_bug.cgi?id=53427

API Changes

None

Behavioral Changes

UAP EntryCell default label styling change.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit ff7a3bc into master Mar 27, 2017
@rmarinho rmarinho deleted the Bz53427 branch June 22, 2017 10:48
@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018
@samhouts samhouts added this to Done in v3.6.0 Jun 26, 2018
@samhouts samhouts removed this from Done in v3.6.0 Jun 26, 2018
@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants