This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix 53427; Change default UAP styling for a label #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Unexpected styling for UWP EntryCell label: https://bugzilla.xamarin.com/attachment.cgi?id=20400
The user expected the EntryCell label styling to match the SwitchCell label styling. EntryCell style is set here:
Xamarin.Forms/Xamarin.Forms.Platform.UAP/Resources.xaml
Line 427 in c65a9a8
As you can see it sets
Foreground="{Binding LabelColor, Converter={StaticResource ColorConverter}, ConverterParameter=SystemControlBackgroundChromeMediumLowBrush}"
.This must have been added to allow coloring the label (prob to red to indicate validation error) however no other controls allow coloring the label -- just EntryCell. Which is fine but there is no precedent for the
ConverterParameter
. Currently its value isSystemControlBackgroundChromeMediumLowBrush
but I think it should beDefaultTextForegroundThemeBrush
.Bugs Fixed
Bug https://bugzilla.xamarin.com/show_bug.cgi?id=53427
API Changes
None
Behavioral Changes
UAP EntryCell default label styling change.
PR Checklist