New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 53427; Change default UAP styling for a label #837

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
4 participants
@kingces95
Member

kingces95 commented Mar 23, 2017

Description of Change

Unexpected styling for UWP EntryCell label: https://bugzilla.xamarin.com/attachment.cgi?id=20400

The user expected the EntryCell label styling to match the SwitchCell label styling. EntryCell style is set here:

<TextBlock Text="{Binding Label}" Style="{ThemeResource BaseTextBlockStyle}" Foreground="{Binding LabelColor, Converter={StaticResource ColorConverter}, ConverterParameter=SystemControlBackgroundChromeMediumLowBrush}" />
.

As you can see it sets Foreground="{Binding LabelColor, Converter={StaticResource ColorConverter}, ConverterParameter=SystemControlBackgroundChromeMediumLowBrush}".

This must have been added to allow coloring the label (prob to red to indicate validation error) however no other controls allow coloring the label -- just EntryCell. Which is fine but there is no precedent for the ConverterParameter. Currently its value is SystemControlBackgroundChromeMediumLowBrush but I think it should be DefaultTextForegroundThemeBrush.

Bugs Fixed

Bug https://bugzilla.xamarin.com/show_bug.cgi?id=53427

API Changes

None

Behavioral Changes

UAP EntryCell default label styling change.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit ff7a3bc into master Mar 27, 2017

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3749, ignored: 10
Details

@rmarinho rmarinho deleted the Bz53427 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment