This repository has been archived by the owner on May 1, 2024. It is now read-only.
Allow to use SwipeItem only with text or icon #8822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
reviewed
Jan 10, 2020
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue8777.cs
Outdated
Show resolved
Hide resolved
jfversluis
approved these changes
Jan 10, 2020
kingces95
approved these changes
Jan 13, 2020
samhouts
added
the
approved
|
All tests passed! Resolving conflicts... |
|
@jsuarezruiz Would you please resolve the conflict? Thanks!! |
samhouts
added
the
i/high
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow to use SwipeItem only with text or icon.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
System.NullReferenceExceptionhas been thrown on iOS, no centered icon on Android.After
Testing Procedure
Launch Core Gallery and navigate to the issue 8777. Open the SwipeView and verify that only appears the centered icon.
PR Checklist