Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Allow user interaction in SwipeItemView #8832

Merged
merged 6 commits into from Feb 4, 2020
Merged

Allow user interaction in SwipeItemView #8832

merged 6 commits into from Feb 4, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Dec 10, 2019 •
edited by samhouts

Description of Change

Allow user interaction in SwipeItemView.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

Entry in custom SwipeItemView can't gain focus.

After

Android
issue8779-droid-after
iOS
issue8779-ios-after

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added p/iOS 🍎 p/Android i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often a/swipeview labels Dec 10, 2019
@samhouts samhouts added this to In Review in v4.4.0 Dec 13, 2019
@samhouts samhouts changed the base branch from 4.4.0 to 4.5.0 January 9, 2020 18:22
@samhouts samhouts removed this from In Review in v4.4.0 Jan 9, 2020
jfversluis
jfversluis suggested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it affects both iOS and Android right?

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue8779.xaml.cs Outdated Show resolved Hide resolved
@samhouts samhouts assigned jfversluis and unassigned jfversluis Jan 14, 2020
@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Feb 3, 2020
@samhouts samhouts added this to In Review in SwipeView Feb 4, 2020
@samhouts
Copy link
Member

samhouts commented Feb 4, 2020

@jsuarezruiz Please rebase to fix conflicts! Thanks!

Failing tests are not related.

@samhouts @jfversluis
Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Sh…
b678d35 
…ared/Issue8779.xaml.cs

Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
@samhouts samhouts requested review from samhouts and removed request for PureWeen February 4, 2020 02:31
@samhouts samhouts assigned samhouts and unassigned PureWeen Feb 4, 2020
@samhouts samhouts merged commit 2cfe212 into 4.5.0 Feb 4, 2020
SwipeView automation moved this from In Review to Done Feb 4, 2020
@samhouts samhouts deleted the fix-8779 branch February 4, 2020 18:28
@samhouts samhouts added this to the 4.5.0 milestone Feb 5, 2020
@samhouts samhouts added this to Done in v4.5.0 Feb 12, 2020
@samhouts samhouts removed this from Done in SwipeView May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VladislavAntonyuk VladislavAntonyuk VladislavAntonyuk left review comments

@jfversluis jfversluis jfversluis requested changes

@kingces95 kingces95 Awaiting requested review from kingces95

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@kingces95 kingces95

@samhouts samhouts

Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. ControlGallery i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
v4.5.0
  
Done
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsuarezruiz @samhouts @jfversluis @VladislavAntonyuk @kingces95 @PureWeen