This repository has been archived by the owner on May 1, 2024. It is now read-only.
[MacOS] Fix NRE with NavigationPage on pre-Mojave #8950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
approved these changes
Dec 20, 2019
samhouts
approved these changes
Jan 1, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes NRE when using Xamarin.Forms with Mac OS on pre-Mojave OS versions with a
NavigationPageIssues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
From #6981 we used a property that is available only from Mojave (10.14) and up. This causes an NRE on apps using Xamarin.Forms on OS versions older than that. This change checks the OS version first.
Before/After Screenshots
Not applicable
Testing Procedure
Run the gallery app on a pre-Mojave machine
PR Checklist