This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Device) #9144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the repro and UITest I can see that it is currently the speed of the swipe that determines if the swipe is being picked up by the Shell Menu or by the SwipeView. Slower swipes are picked up by the SwipeView, while faster swipes are picked up by the Shell Menu. I’ve looked at the iOS SwipeView Renderer, but I cannot identify a root cause from this. The issue is too tricky for my current understanding of how Shell and SwipeView is constructued. I was hoping that you might have some insights here? Thanks |
jsuarezruiz
changed the title
Repro and UITest for Issue 9088
[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Device)
Mar 6, 2020
@1iveowl Thank you very much for your PR. With the repro sample it has been easier to fix the issue. I have applied changes to your PR to add the fix and have verified it in simulator and devices. |
jsuarezruiz
suggested changes
Mar 6, 2020
@samhouts Should we retarget this to 4.5? |
jsuarezruiz
approved these changes
Mar 12, 2020
This comment has been minimized.
This comment has been minimized.
samhouts
requested review from
PureWeen
and removed request for
StephaneDelcroix and
samhouts
March 24, 2020 17:52
samhouts
added
the
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
label
Aug 4, 2020
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
…e) (xamarin#9144) * start * Start * UI Test compete * Added cast SwipeView issue fix Co-authored-by: Jasper Hedegaard Bojsen <jasperhb@outlook.com> Co-authored-by: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com> fixes xamarin#9088
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…e) (xamarin#9144) * start * Start * UI Test compete * Added cast SwipeView issue fix Co-authored-by: Jasper Hedegaard Bojsen <jasperhb@outlook.com> Co-authored-by: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com> fixes xamarin#9088
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…e) (xamarin#9144) * start * Start * UI Test compete * Added cast SwipeView issue fix Co-authored-by: Jasper Hedegaard Bojsen <jasperhb@outlook.com> Co-authored-by: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com> fixes xamarin#9088
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/collectionview
a/gestures 🖖
a/maps 🌐
a/shell 🐚
a/swipeview
a/visual
ControlGallery
Core
p/Android
p/gtk
p/iOS 🍎
p/macOS
p/Tizen
p/UWP
p/WPF
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
t/bug 🐛
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix touch conflict between Shell Flyout and SwipeView (on Device).
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
See provided UITest
PR Checklist