This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make CarouselView.IsBounceEnabled work on initialization #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
Jan 13, 2020
hartez
approved these changes
Jan 13, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make control aware of the
IsBounceEnabledvalue on initialization on Android.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
When setting
IsBounceEnabledfrom XAML it wouldn't work since the property was not propagated to the native control on initialization, only when the property was set.Before/After Screenshots
Not applicable
Testing Procedure
Go to CarouselView Core Gallery and find the new IsBounceEnabled option. When swiping from left to right you should not see the Android overscroll animation. On other CarouselView Core Gallery options you should see it.
PR Checklist