This repository has been archived by the owner on May 1, 2024. It is now read-only.
Embed templates #9225
Merged
Embed templates #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jan 15, 2020
| AToolbar bar = null; | ||
|
|
||
| #if __ANDROID_29__ | ||
| if (ToolbarResource == 0) |
There was a problem hiding this comment.
If you're using API 29 and these Ids are zero then just set them using the internal layout ids.
The one breaking change from this will be if
- users update to androidx
- have no transitive libraries
- they've customized the head project layouts to be different than the forms templates
- In which case they should get the error message below
PureWeen
commented
Jan 15, 2020
| ie.Message == "Binary XML file line #1: Error inflating class android.support.v7.widget.Toolbar" && | ||
| this.TargetSdkVersion() >= 29) | ||
| { | ||
| Internals.Log.Warning(nameof(FormsAppCompatActivity), |
There was a problem hiding this comment.
If inflation fails and all the above criteria then output a message explaining how to upgrade the templates to Android X or just inform the user that they can delete the layouts all together
PureWeen
commented
Jan 15, 2020
|
|
||
| if (ToolbarResource == 0) | ||
| { | ||
| ToolbarResource = Resource.Layout.FallbackToolbarDoNotUse; |
There was a problem hiding this comment.
Fall back to some AndroidX templates that haven't been replaced by the project head
samhouts
approved these changes
Jan 16, 2020
PureWeen
commented
Jan 16, 2020
Xamarin.Forms.Platform.Android/AppCompat/FormsAppCompatActivity.cs
Outdated
Show resolved
Hide resolved
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
PureWeen
added
the
blocker
rmarinho
approved these changes
Jan 23, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Account for edge cases where the android head project has zero transitive support library references but is still utilizing the defaults forms layouts
Testing Procedure
Create a Xamarin.Forms application from the template
PR Checklist