[REVERTED] [MediaElement] Removed line that pauses player before setting it to null.

[StevenGranados]

Description of Change

Removed line that pauses player before setting it to null.
I think the pause is there to stop background playback of the media element, but since the next line also seems to stop it, I removed the line.
I appreciate there is probably a lot more going on here though @peterfoot .
I'm not sure how to handle the video source, there has to be one for the exception to occur. It's currently taking a hard-coded URL source.

Issues Resolved

• fixes (but reverted) [Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

API Changes

None

Platforms Affected

• iOS

Behavioral/Visual Changes

Will now not give an exception on Dispose.

Before/After Screenshots

Not applicable

Testing Procedure

Have a page in iOS with a media element. Change page so that the media element is disposed.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[dnfclas]

All CLA requirements met.

[peterfoot]

Good catch, the Pause does now seem redundant

[StevenGranados]

This is my first pull request, so I've almost certainly done something wrong on my UITest. Seeing as it is a simple fix on a new control, maybe best if the test is removed?

[samhouts]

Looks good, just need to fix the test.

[samhouts]

We need to find a video that won't disappear on us. Something uploaded to the source, perhaps.

[StevenGranados]

#9525 (comment)
This comment seems to suggest a better fix than mine.

[rmarinho]

Hey @StevenGranados can you fix the flag and upload a video so we can use on the repo? thanks

[StevenGranados]

I don't know how to put files in the source. I think there might have to be a new type of MediaSource to allow for it. At the moment there is Uri and File (I assume from the device file system).
I've tried to put a video in as an embedded resource, but I can't use streams in the Source property.
I've tried to put a video in each project separately (Resources folder and set to BundleResource) and refer to the filename in the Source property, but I'm not having any joy. @peterfoot any ideas?

[StevenGranados]

#11417 uses a Uri in the Source parameter. I assume you can control the availability of this?

[peterfoot]

@StevenGranados I think @rmarinho just meant a video online in a location which won't change. Personally I've always found this to be an issue, even when testing against Channel 9 videos e.g. https://sec.ch9.ms/ch9/80a3/6563611f-6a39-44fa-a768-1a58bdd080a3/HotRestart.mp4 So I'd suggest something like that which should hopefully be stable for months if not longer.

[StevenGranados]

@rmarinho I've made some changes

[PureWeen]

@peterfoot @StevenGranados FYI

#11862