Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Androidx material bump #9701

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Androidx material bump #9701

merged 6 commits into from
Dec 16, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Feb 24, 2020 •
edited

Description of Change

Update Xamarin.Google.Android.Material 1.1.0-rc3

Issues Resolved

Platforms Affected

  • Android

Behavioral/Visual Changes

In theory there shouldn't be any. Compare the Visual Gallery on the previous version to this one

Testing Procedure

  • open visual gallery, compare to ios, and compare to previous version

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Feb 24, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Feb 24, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Feb 27, 2020
@samhouts samhouts removed this from In Progress in v4.6.0 Mar 2, 2020
@PureWeen PureWeen mentioned this pull request Mar 22, 2020
Open
@PureWeen PureWeen removed the request for review from Redth March 30, 2020 23:58
@PureWeen
Copy link
Contributor Author

PureWeen commented Apr 9, 2020

Currently blocked by
xamarin/AndroidX#76

@samhouts samhouts added this to In progress in Visual Apr 23, 2020
@samhouts samhouts changed the base branch from master to 4.8.0 June 26, 2020 00:08
@samhouts samhouts changed the base branch from 4.8.0 to main July 29, 2020 23:41
@samhouts samhouts added this to In Progress in .NET MAUI Backlog Jul 30, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@PureWeen PureWeen changed the base branch from main to 5.0.0 August 27, 2020 20:11
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 27, 2020
@samhouts samhouts removed this from In Progress in .NET MAUI Backlog Aug 27, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 27, 2020
@rmarinho rmarinho added this to In progress in v5.0.1 via automation Oct 30, 2020
@rmarinho rmarinho removed this from In Progress in vNext+1 (5.0.0) Oct 30, 2020
@rmarinho rmarinho moved this from In progress to Review in progress in v5.0.1 Oct 30, 2020
@PureWeen PureWeen added this to the 5.0.1 milestone Nov 2, 2020
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Nov 3, 2020
@PureWeen PureWeen requested a review from hartez December 11, 2020 16:35
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Dec 11, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Dec 11, 2020
@PureWeen PureWeen removed this from Review in progress in v5.0.1 Dec 11, 2020
@PureWeen PureWeen modified the milestones: 5.0.1, 5.0.0 Dec 11, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Dec 11, 2020
@PureWeen
Copy link
Contributor Author

@rmarinho I tested the nugets on this one and it pulls in the right nuget versions

 "Xamarin.AndroidX.Annotation/1.1.0.7": {
        "type": "package",
        "dependencies": {
          "Xamarin.AndroidX.Migration": "1.0.8"
        },

@PureWeen PureWeen requested review from rmarinho and removed request for moljac December 15, 2020 18:41
jsuarezruiz
jsuarezruiz suggested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some differences with the change. For example (left updated version, right 5.0.0 branch).

material-changes

@PureWeen PureWeen mentioned this pull request Dec 16, 2020
Open
@rmarinho rmarinho merged commit 16107f9 into 5.0.0 Dec 16, 2020
vNext+1 (5.0.0) automation moved this from To do to Done Dec 16, 2020
@rmarinho rmarinho deleted the androidx_material_bump branch December 16, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@rmarinho rmarinho rmarinho approved these changes

@hartez hartez Awaiting requested review from hartez

Assignees

@hartez hartez

@rmarinho rmarinho

@jsuarezruiz jsuarezruiz

Labels
a/visual blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. ControlGallery p/Android
Projects
Visual
  
In progress
vNext+1 (5.0.0)
Done
Milestone
5.0.0
5 participants
@PureWeen @hartez @rmarinho @jsuarezruiz @samhouts