[GH-6184] - Make able to disable tabs inside the MoreViewController [iOS]

[pictos]

Description of Change

Now the XF doesn't throw an exception when a TabBarItem in MoreViewController has IsEnabled = false.

Issues Resolved

• partially fixes [Bug] Invalid TabBar.Items access in iOS ShellItemRenderer #6184

API Changes

Added:

• local function void SetEnabledForMoreController() in ShellItemRenderer.CreateTabRenderers()

Platforms Affected

• iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Before:
throws Exception

Now:

Testing Procedure

Create a Shell Bottom Tab application with more than 5 tabs, and set IsEnabled property to false.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[PureWeen]

@pictos can you rebase this against master?

[pictos]

@PureWeen, I did the rebase.

[PureWeen]

@pictos it doesn't look like it was done quite correctly

if you look at the changed files
https://github.com/xamarin/Xamarin.Forms/pull/9781/files

there is a bunch of stuff there that shouldn't be there

[pictos]

I saw I'm looking on that 😅

[pictos]

@PureWeen, can you look to see if I fixed it?

[PureWeen]

@pictos 👍

Kicked off the UI Tests

[pictos]

@PureWeen this error is related to my changes?

[PureWeen]

@pictos looking at your branch it doesn't look like it's been rebased to master. Your master branch looks updated though

when you're on your gh-6184 try

git rebase master

And then do a force push

[pictos]

@PureWeen, one more try, and fingers crossed 🤞🏾

[PureWeen]

@pictos it looks like GitHubIssue6184_apple_iphone_11_pro_13_3_1

Is failing on all our iOS UI tests

[pictos]

@PureWeen, the error from CI is:
System.Exception : Error while performing Tap(Marked("Issue 5"))
----> System.Exception : Unable to tap element. Query for Marked("Issue 5") gave no results.

can I ignore the UITest? I would not able to run it on my machine, but the test is passing manually.

[pictos]

@PureWeen, any update on this?

[pictos]

@PureWeen, I fixed the UITest, can you run it, please?

[pictos]

@PureWeen, the tests that failed don't seem to be related to this PR, is that correct?

[pictos]

@PureWeen I did some improvements in the code and for now, I removed support for iOS14. Looks like Apple changed the API and I'll need more time to find how to access the cells inside the More UITableView. I don't know if they closed the API or changed it to another place, or if is missing something in the bindings.

[PureWeen]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[PureWeen]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[PureWeen]

UI Tests
https://dev.azure.com/xamarin/public/_releaseProgress?_a=release-pipeline-progress&releaseId=2468

[PureWeen]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.