This repository has been archived by the owner on May 1, 2024. It is now read-only.
[build] attempt at signing .nupkg #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on: xamarin/Xamarin.Android.FSharp.ResourceProvider#8 * Bump to Microsoft.NET.Workload.Android-11.0.200-ci.master.40 for consistency
jonathanpeppers
force-pushed
the
signing
branch
from
072ba38
to
d8a09f9
Compare
pjcollins
approved these changes
Jan 21, 2021
mattleibow
reviewed
Jan 22, 2021
| @@ -47,6 +66,13 @@ jobs: | |||
| artifact: windows | |||
| targetPath: bin | |||
| condition: succeededOrFailed() | |||
| # NOTE: that PublishBuildArtifacts is required for signing | |||
There was a problem hiding this comment.
There was a PR to change this, or at least support the other way. I think a property was added. But, this is not required.
There was a problem hiding this comment.
It failed when I used PublishPipelineArtifact in a weird way:
But I'm fine to use PublishBuildArtifacts, it works. 👍
There was a problem hiding this comment.
Again I don't have a link on my phone, but I found the PR and it was not merged yet. 🙃
There was a problem hiding this comment.
This one: https://github.com/xamarin/yaml-templates/pull/96
But I'm fine to leave this as it is.
There was a problem hiding this comment.
Yup, but yeah. No need to change. Just was an FYI for future things.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: xamarin/Xamarin.Android.FSharp.ResourceProvider#8