Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure DevOps YAML build file #710

Merged
merged 4 commits into from Mar 4, 2020
Merged

Conversation

mcumming
Copy link
Contributor

@mcumming mcumming commented Feb 25, 2020

  • Build master, release branches commit and PR's
  • Processes translations from localization pipeline
  • Update README to point at new pipeline
  • Added github action to auto-create PR when trnaslations are pushed on loc branch.

Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1052929

@CartBlanche
Copy link
Contributor

@mcumming So is this change to automate pulling in the translations?

Are there now 2 builds going on? One for translation over on https://dev.azure.com/xamarin/public/_build?definitionId=50 and the other on https://devdiv.visualstudio.com/DevDiv/_build/latest?definitionId=5330 or does this means we only have 1 build happening now?

I'm just trying to understand what we are trying to achieve as I have no context for this PR.

@mcumming
Copy link
Contributor Author

@mcumming So is this change to automate pulling in the translations?

Are there now 2 builds going on? One for translation over on https://dev.azure.com/xamarin/public/_build?definitionId=50 and the other on https://devdiv.visualstudio.com/DevDiv/_build/latest?definitionId=5330 or does this means we only have 1 build happening now?

I'm just trying to understand what we are trying to achieve as I have no context for this PR.

This will replace the existing build definition which is private with one that is publicly accessible, and includes translation processing.

@mcumming mcumming closed this Feb 25, 2020
@mcumming mcumming reopened this Feb 25, 2020
@CartBlanche
Copy link
Contributor

CartBlanche commented Feb 25, 2020

@mcumming Any ideas about the failing build?

@mcumming
Copy link
Contributor Author

mcumming commented Mar 3, 2020

@mcumming Any ideas about the failing build?

@CartBlanche Resolved.

Copy link
Contributor

@CartBlanche CartBlanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like another pair of eyes on it, if that is ok, before pulling it in.

@mcumming mcumming merged commit a0c4622 into master Mar 4, 2020
@mcumming mcumming deleted the loc_handoff_automation branch March 4, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants