Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Add Bindings support for ImageResourceExtension #1002

Closed
1 of 2 tasks
Cfun1 opened this issue Mar 3, 2021 · 1 comment · Fixed by #1068
Closed
1 of 2 tasks

[Enhancement] Add Bindings support for ImageResourceExtension #1002

Cfun1 opened this issue Mar 3, 2021 · 1 comment · Fixed by #1068
Labels
feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before!

Comments

@Cfun1
Copy link
Contributor

Cfun1 commented Mar 3, 2021

Summary

With the actual ImageResource xaml extension ImageResourceExtension.shared.cs it is not possible to use Bindings.

What do you guys think about implementing a converter for this extension like it is already done for some of the converters?

I have tried to derive from BindableObject to use bindable properties but the main issue is that ProvideValue() will always fire first before the property changed event does, so it seems using Bindings with IMarkupExtension won't be straightforward.

As a solution:
- Create a new converter for the same purpose.
- Or apply/update/resolve/manage the Bindings our-self inside ProvideValue() starting from a string property (Path & Source of Bindings) set by the dev (seems there is some approaches to it but they look complicated not practical IMHO https://stackoverflow.com/a/43866357/).

Who Will Do The Work?

  • I am willing to take this on myself
  • Just putting this out there for someone to pick up
@Cfun1 Cfun1 added feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before! labels Mar 3, 2021
@Cfun1 Cfun1 mentioned this issue Mar 12, 2021
5 tasks
@Cfun1
Copy link
Contributor Author

Cfun1 commented Mar 14, 2021

Closed in #1068

@Cfun1 Cfun1 closed this as completed Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant