-
Notifications
You must be signed in to change notification settings - Fork 474
[Bug] DrawingView.ClearOnFinish
seems to have no effect
#1453
Comments
@jfversluis It is expected behavior. We should clear the screen when the customer starts drawing independently from the ClearOnFinish. We do not allow multiple lines, because of Points collection. it should be Collection of Collection of Points to support multiple lines. I described some properties here: https://vladislavantonyuk.azurewebsites.net/articles/Drawing-View-in-Xamarin-Community-toolkit |
Interesting, I see how it's supposed to work now, thanks for clearing that up. I think it would be nice to also have the ability to draw multiple lines independently. I don't fully understand why that should be a problem? The points can be duplicate or overlapping or anything right? But maybe I'm not fully understanding how this works. We should follow up in a new issue probably |
we draw the line as an array of points (we draw the line between two points). so when we set the points, we will draw the line between the last point of "Line1" and the first point of "Line2". |
Fixed in #1459 |
I'm releasing it NOW! :P So don't worry about it. We'll make it something for the next release |
Description
Maybe I'm misunderstanding what this does. I expect that this property would leave my current drawing in place when I start to draw a second line. However, this is not the case. Khttps://github.com/xamarin/XamarinCommunityToolkit/blob/develop/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.ios.cs#L79 it is correctly checked and the collection is not cleared, however here the collection is still cleared.
Only tested on iOS, but looking at the Android renderer same thing happens there, so will be good to check all platforms.
Steps to Reproduce
DrawingView
like belowExpected Behavior
Both lines are shown on the canvas
Actual Behavior
Only one line at a time is shown on the canvas
Basic Information
Workaround
None that I know of right now
Reproduction imagery
Reproduction Link
The text was updated successfully, but these errors were encountered: