This repository has been archived by the owner on May 1, 2024. It is now read-only.
Update packages, Fix WPF Sample app #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected override void OnAppearing() | ||
| { | ||
| base.OnAppearing(); | ||
| (BindingContext as BaseGalleryViewModel)?.FilterCommand.Execute(string.Empty); |
There was a problem hiding this comment.
hack for WPF sample to fix layout issue
VladislavAntonyuk
force-pushed
the
update-package
branch
from
ec64e93
to
c597ef2
Compare
VladislavAntonyuk
force-pushed
the
update-package
branch
from
c597ef2
to
b121bde
Compare
brminnick
suggested changes
Dec 17, 2021
src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj
Show resolved
Hide resolved
src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj
Show resolved
Hide resolved
src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj
Show resolved
Hide resolved
src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj
Show resolved
Hide resolved
src/Markup/Xamarin.CommunityToolkit.Markup/Xamarin.CommunityToolkit.Markup.csproj
Show resolved
Hide resolved
|
Ah - got it. So we have to update the Xamarin.Forms dependency in order to fix the WPF bug in the Toolkit. |
|
yes, bug #606 |
brminnick
approved these changes
Jan 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Update Nuget packages to the latest version, Fix WPF Sample app #606
PR Checklist
approved