Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix random crash on iOS when switching source #1899

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

mphill
Copy link
Contributor

@mphill mphill commented Aug 24, 2022

Description of Bug

Random crash on iOS with media element and switching sources. I fixed an identical issue with https://github.com/Baseflow/XamarinMediaManager/blob/f72ededd4be0e7c09125e07da2a6627d8b0caeb0/MediaManager/Platforms/Apple/AppleMediaManagerBase.cs

Issues Fixed

Behavioral Changes

None

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much @mphill

@bijington bijington merged commit f3a4251 into xamarin:main Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MediaElement exception when fast changing Source few times
2 participants