This repository has been archived by the owner on May 1, 2024. It is now read-only.
PopupRenderer: check for isDisposed in OnElementPropertyChanged before taking action. Fixes https://github.com/xamarin/XamarinCommunityToolkit/issues/1947 #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e taking action. Fixes xamarin#1947
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
cf #1947
Issues Fixed
Add a check for
isDisposedand make sure the code has the same safeguards in all versions of the renderer. No new tests or samples should be needed.Behavioral Changes
None of significance.
PR Checklist
approved