Conversation
69a0fc9
to
883f995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dansiegel thanks for this amazing contribution. I didn't run the code yet to test. Do you mind adding some unit tests? If you can't do it don't worry I'll do it in the future (:
XamarinCommunityToolkit/Views/GravatarImageSource/UWP/GravatarImageSourceHandler.uwp.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/UWP/GravatarImageSourceHandler.uwp.cs
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/MacOS/GravatarImageSourceHandler.macos.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/Wpf/GravatarImageSourceHandler.wpf.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/iOS/GravatarImageSourceHandler.ios.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarImageExtension.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarImageSource.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarImageSource.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarImageSource.shared.cs
Outdated
Show resolved
Hide resolved
883f995
to
e163bc5
Compare
XamarinCommunityToolkit/Extensions/GravatarImageExtension.shared.cs
Outdated
Show resolved
Hide resolved
e163bc5
to
6386331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
6386331
to
bdf5219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dansiegel we are getting there❣ Most of the comments are about code style.
XamarinCommunityToolkit/Views/GravatarImageSource/iOS/GravatarImageSourceHandler.ios.macos.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
XamarinCommunityToolkit/Views/GravatarImageSource/GravatarHandlerUtil.shared.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs others review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build seems to fail
Views/GravatarImageSource/Android/GravatarImageSourceHandler.android.cs(20,13): error CS1996: Cannot await in the body of a lock statement
@jfversluis good catch... I'll update that shortly |
…lerUtil.shared.cs
…lerUtil.shared.cs
…lerUtil.shared.cs
…lerUtil.shared.cs
354750b
to
f11dbdf
Compare
f11dbdf
to
6887d79
Compare
Description of Change
Adds a new GravatarImageSource that can be easily added for any image source using a user's email address. This utilizes the image provided by gravatar.com and supports all of their default image results to handle when an email address has no associated Gravatar.
Issues
Platforms Supported
API Changes
Added:
Note that by default Caching is enabled for 7 days. An additional XAML Extension has been provided to make it even easier to use.
Behavioral Changes
none
PR Checklist