This repository was archived by the owner on May 1, 2024. It is now read-only.
User stopped typing behavior extend with minimum text length property#389
Merged
Conversation
…imum-text-length-property
AndreiMisiukevich
approved these changes
Oct 9, 2020
jfversluis
approved these changes
Oct 9, 2020
Contributor
|
@jfversluis @jBijsterboschNL I am going to try to work around the "IsFocused" issue in the follow-up PR (If I will be lucky enough with this problem) For now, it's 💯 approval from my side |
Contributor
Author
|
@AndreiMisiukevich, I would love to hear from you once you're able to work around this 'IsFocused' issue from a unit test standpoint :) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Implemented MinimumLengthThreshold on UserStoppedTypingBehavior.
Bugs Fixed
API Changes
Added:
int MinimumLengthThreshold { get; set; }on UserStoppedTypingBehaviorBehavioral Changes
There is now also an option to set the minimum number of characters, along with the time threshold option, before the Command is being executed.
PR Checklist