Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

User stopped typing behavior extend with minimum text length property#389

Merged
jfversluis merged 4 commits into
xamarin:mainfrom
jBijsterboschNL:user-stopped-typing-behavior-extend-with-minimum-text-length-property
Oct 9, 2020
Merged

User stopped typing behavior extend with minimum text length property#389
jfversluis merged 4 commits into
xamarin:mainfrom
jBijsterboschNL:user-stopped-typing-behavior-extend-with-minimum-text-length-property

Conversation

@jBijsterboschNL

Copy link
Copy Markdown
Contributor

Description of Change

Implemented MinimumLengthThreshold on UserStoppedTypingBehavior.

Bugs Fixed

API Changes

Added:

  • int MinimumLengthThreshold { get; set; } on UserStoppedTypingBehavior

Behavioral Changes

There is now also an option to set the minimum number of characters, along with the time threshold option, before the Command is being executed.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@dnfadmin

dnfadmin commented Oct 8, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment thread XamarinCommunityToolkitSample/Resx/AppResources.Designer.cs
@jfversluis jfversluis added a/behaviors This issue/PR is related to behaviors api-change 🚨 ready-to-merge Review completed, Ready for API review and merge labels Oct 9, 2020
@jfversluis jfversluis added this to the v1.0 milestone Oct 9, 2020
@AndreiMisiukevich

AndreiMisiukevich commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

@jfversluis @jBijsterboschNL I am going to try to work around the "IsFocused" issue in the follow-up PR (If I will be lucky enough with this problem)

For now, it's 💯 approval from my side

@jfversluis jfversluis merged commit 3da67eb into xamarin:main Oct 9, 2020
@jBijsterboschNL

Copy link
Copy Markdown
Contributor Author

@AndreiMisiukevich, I would love to hear from you once you're able to work around this 'IsFocused' issue from a unit test standpoint :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a/behaviors This issue/PR is related to behaviors api-change 🚨 ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Extend UserHasStoppedTypingBehavior with a minimum text length property

4 participants