Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

ReachabilitySample code may cause your app to fail the Apple approval process due to IPv6 requirement #106

Closed
trevoriancox opened this issue Aug 28, 2016 · 4 comments
Closed

ReachabilitySample code may cause your app to fail the Apple approval process due to IPv6 requirement #106

trevoriancox opened this issue Aug 28, 2016 · 4 comments

Comments

@trevoriancox
Copy link

Has hard-coded IPv4 addresses. See https://blog.xamarin.com/making-your-ios-apps-ipv6-ready/
@olegoid
Copy link
Contributor

olegoid commented Sep 5, 2016 •
edited

Thanks @trevoriancox! Should be fixed in 228de75

@olegoid olegoid closed this as completed Sep 5, 2016
olegoid added a commit that referenced this issue Sep 5, 2016
@olegoid
[ReachabilitySample] Refresh sample:
228de75 
* Fix code formatting
* Add IPv6 conversion - issues #106
@gijsstegehuis
Copy link

@olegoid your fix in 228de75 solves the IPv6 issue, but now it stopped working on IPv4 networks.

@jamesmontemagno
Copy link

I actually don't think they had to be changed at all. These actually are whitelisted IPs that Apple will accept. See: jamesmontemagno/ConnectivityPlugin#11

@trevoriancox
Copy link
Author

Maybe Apple's testing was flawed, but updating from this to Connectivity Plugin v2.x (not just 1.x) seems to have resolved our app approval issues.

@conceptdev conceptdev mentioned this issue Sep 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@olegoid @jamesmontemagno @trevoriancox @gijsstegehuis