[Java.Interop.BootstrapTasks] Use JdkInfo #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
approved these changes
Jul 27, 2018
jonpryor
force-pushed
the
jonp-xat-JdkInfo
branch
from
e3a940d
to
6cc47ca
Compare
There was a problem hiding this comment.
I think something is happening on Windows:
build-tools\scripts\PrepareWindows.targets(15,5): Error MSB3202: The project file "E:\A\_work\4\s\build-tools\scripts\..\..\src\Java.Interop.BootstrapTasks\Java.Interop.BootstrapTasks.csproj" was not found.
Process 'msbuild.exe' exited with code '1'.
Oh, this path changed:
Context: xamarin/xamarin-android-tools#29 (comment) Bumps to xamarin/xamarin-android-tools:master@75530565 The `<JdkInfo/>` task within `Java.Interop.BootstrapTasks.dll` isn't the *only* thing that needs to determine the path of an installed JDK. The IDEs could also use such functionality, as could xamarin-android. Add a submodule reference to xamarin-android-tools, and use `Xamarin.Android.Tools.JdkInfo` to find the preferred JDK, instead of having lots of custom probing with the `<JdkInfo/>` task. Finally, for consistency, move `src/Java.Interop.BootstrapTasks` to `build-tools/Java.Interop.BootstrapTasks`, as the `Java.Interop.BootstrapTasks.dll` assembly is only intended for in building Java.Interop *itself*, and not for "downlevel" distribution.
jonpryor
force-pushed
the
jonp-xat-JdkInfo
branch
from
6cc47ca
to
89e9365
Compare
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Aug 25, 2018
Context: xamarin/java.interop@78f7301...893562c Use JdkInfo during the build: xamarin/java.interop#349 Optimize type lookups: xamarin/java.interop#350 [jnimarshalmethod-gen] --types option: xamarin/java.interop@d174fa6 Remove unused XAIntegration $(Configuration): xamarin/java.interop#361 Option to build Java.Interop as non-PCL: xamarin/java.interop#360
dellis1972
pushed a commit
to xamarin/xamarin-android
that referenced
this pull request
Aug 26, 2018
Context: xamarin/java.interop@78f7301...893562c Use JdkInfo during the build: xamarin/java.interop#349 Optimize type lookups: xamarin/java.interop#350 [jnimarshalmethod-gen] --types option: xamarin/java.interop@d174fa6 Remove unused XAIntegration $(Configuration): xamarin/java.interop#361 Option to build Java.Interop as non-PCL: xamarin/java.interop#360
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/xamarin-android-tools#29 (comment)
Bumps to xamarin/xamarin-android-tools:master@75530565
The
<JdkInfo/>task withinJava.Interop.BootstrapTasks.dllisn'tthe only thing that needs to determine the path of an installed JDK.
The IDEs could also use such functionality, as could xamarin-android.
Add a submodule reference to xamarin-android-tools, and use
Xamarin.Android.Tools.JdkInfoto find the preferred JDK, instead ofhaving lots of custom probing with the
<JdkInfo/>task.Finally, for consistency, move
src/Java.Interop.BootstrapTaskstobuild-tools/Java.Interop.BootstrapTasks, as theJava.Interop.BootstrapTasks.dllassembly is only intended for inbuilding Java.Interop itself, and not for "downlevel" distribution.