Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output #622

Merged
merged 1 commit into from Apr 13, 2020
Merged

[Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/DirectoryAssemblyResolver.cs
View file
Open in desktop
Expand Up @@ -163,9 +163,9 @@ protected virtual AssemblyDefinition ReadAssembly (string file)
return AssemblyDefinition.ReadAssembly (file, reader_parameters);
} catch (Exception ex) {
logger (
TraceLevel.Warning,
TraceLevel.Verbose,
$"Failed to read '{file}' with debugging symbols. Retrying to load it without it. Error details are logged below.");
logger (TraceLevel.Warning, $"{ex.ToString ()}");
logger (TraceLevel.Verbose, $"{ex.ToString ()}");
reader_parameters.ReadSymbols = false;
return AssemblyDefinition.ReadAssembly (file, reader_parameters);
}
Expand Down