Safe browsing sample created #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
requested changes
Jan 17, 2018
| <uses-sdk android:targetSdkVersion="26" android:minSdkVersion="26" /> | ||
| <application android:allowBackup="true" android:icon="@mipmap/icon" android:label="@string/app_name" android:theme="@style/AppTheme"></application> | ||
| <application android:allowBackup="true" android:label="@string/app_name" android:icon="@mipmap/icon" android:theme="@style/AppTheme"></application> | ||
| </manifest> |
There was a problem hiding this comment.
The delta in this file is just extra noise in the PR, we should not include these changes.
| <AndroidResgenClass>Resource</AndroidResgenClass> | ||
| <GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies> | ||
| <AndroidUseLatestPlatformSdk>True</AndroidUseLatestPlatformSdk> | ||
| <TargetFrameworkVersion>v8.0</TargetFrameworkVersion> |
There was a problem hiding this comment.
Let's remove the AndroidUseLatestPlatformSdk tag (set to false), and update TargetFrameworkVersion to v8.1.
android-o/SafeBrowsing/Metadata.xml
Outdated
| <SupportedPlatforms>Android</SupportedPlatforms> | ||
| <LicenseRequirement>Starter</LicenseRequirement> | ||
| <Brief>Demonstrates how to enable safe browsing.</Brief> | ||
| <Gallery>false</Gallery> |
There was a problem hiding this comment.
I think we can set this to true.
@mgmclemore is there any reason for us to disable new samples in the Gallery by default, or is it alright for new samples to set this element to true when they are added?
| public class MainActivity : Activity | ||
| { | ||
| public WebView webView; | ||
| public bool mSafeBrowsingIsInitialized; |
There was a problem hiding this comment.
I'd prefer to have this be a public property:
public bool IsSafeBrowsingEnabled { get; set; }
pjcollins
approved these changes
Jan 17, 2018
pjcollins
added a commit
that referenced
this pull request
Mar 6, 2018
…7.0.2 (#261) * Update Xamarin.Android.Support to 27.0.2 (#251) * Target version updated * support packages updated * Using SearchView instead of SearchViewCompat(was deprecated) (#253) * Safe browsing sample created (#256) * Safe browsing sample created * review comments resolved * Update Xamarin.Android.Support package references to latest 27.0.2 (#260) * Update Xamarin.Android.Support package references to latest 27.0.2 * Fix some incorrect import and error hint paths * Fix more incorrect import and error hint path issues * [Support Components] ViewModel sample (#258) * Created sample * Moved sample into android-support folder * Removed .vs folder * Re-imported nuget packages from VS * Updated target of xamarin.android.support packages to MonoAndroid81 * Android Cipher sample added (#257) * Android Cipher sample added * Readme modified * review comments resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe browsing sample created