-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource directories missed in incremental builds with AndroidAarLibrary
items
#2408
Comments
From the logs this, looks weird
The broken
The input parameters to this task appear to be identical. |
@jonathanpeppers @Redth I think we need to investigate the .cache files that |
Found the Bug. Its in the Aar extraction code I'll do a PR |
Fixed dotnet#2408 As part of the speed up process when extracting resources from assemblies and Aar files, we dont re-extract if the stamp file is newer than the assembly. The problem with that was in the case of Aar files we were NOT adding the `res` or `asset` directories to the list of resolved directories when we skipped extraction. As a result we got less `res` directories on a second build. This commit fixes that.
* [Xamarin.Android.Build.Tasks] Fix Aar directory resolution. Fixed #2408 As part of the speed up process when extracting resources from assemblies and Aar files, we dont re-extract if the stamp file is newer than the assembly. The problem with that was in the case of Aar files we were NOT adding the `res` or `asset` directories to the list of resolved directories when we skipped extraction. As a result we got less `res` directories on a second build. This commit fixes that. * Add Unit Test * Fix Compile Error
) * [Xamarin.Android.Build.Tasks] Fix Aar directory resolution. Fixed dotnet#2408 As part of the speed up process when extracting resources from assemblies and Aar files, we dont re-extract if the stamp file is newer than the assembly. The problem with that was in the case of Aar files we were NOT adding the `res` or `asset` directories to the list of resolved directories when we skipped extraction. As a result we got less `res` directories on a second build. This commit fixes that. * Add Unit Test * Fix Compile Error
…2556) Fixed #2408 As part of the speed up process when extracting resources from assemblies and Aar files, we dont re-extract if the stamp file is newer than the assembly. The problem with that was in the case of Aar files we were NOT adding the `res` or `asset` directories to the list of resolved directories when we skipped extraction. As a result we got less `res` directories on a second build. This commit fixes that. * Update ResolveLibraryProjectImports.cs The usage of `ITaskItem` and item metadata isn't needed on d15-9
Steps to Reproduce
https://github.com/xamarin/Xamarin.Forms.git
and switch to the branchvisual-preview6
nuget.exe restore Xamarin.Forms.sln
msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /bl /t:rebuild
which builds successfullymsbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /bl
which now fails:It looks like the number of directories specified in the call to Aapt is missing a bunch of items in the incremental build vs the rebuild:
This appears to happen when we use Android Support library nuget packages (in this case
28.0.0-preview6
which have the .aar files directly included in them using theAndroidAarLibrary
item group type.Attaching some binary logs of success/error builds for good measure:
binlogs.zip
The text was updated successfully, but these errors were encountered: