InstallAndroidDependencies target does not install platforms or build-tools components on Windows

[brendanzagaeski]

Example steps to reproduce

Adjust the InstallAndroidDependenciesTest to assert that the target Android SDK install directories are created:

diff --git a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs
index 73c32881..62066963 100644
--- a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs
+++ b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs
@@ -24,6 +24,8 @@ namespace Xamarin.Android.Build.Tests
 					string defaultTarget = b.Target;
 					b.Target = "InstallAndroidDependencies";
 					Assert.IsTrue (b.Build (proj, parameters: new string [] { "AcceptAndroidSDKLicenses=true" }), "InstallAndroidDependencies should have succeeded.");
+					Assert.IsTrue (Directory.Exists (Path.Combine (sdkPath, "platforms")), "At least one platform should have been installed");
+					Assert.IsTrue (Directory.Exists (Path.Combine (sdkPath, "build-tools")), "At least one Build Tools version should have been installed");
 					b.Target = defaultTarget;
 					Assert.IsTrue (b.Build (proj), "build should have succeeded.");
 				}

Expected behavior

The test passes when running on Windows. The corresponding build log should include lines that start with:

Downloading archive from ...

and some lines like:

Installing Android SDK component: Android SDK Platform 29 r4 [Platform: API 29]

Actual behavior

The test fails on Windows. The build does not include any Downloading archive or Installing Android SDK component lines. Instead it shows:

No components need to be installed

Preliminary investigation

This appears to be a path separator issue. I tried an experiment where I replaced dependency.ItemSpec with string.Join ("\\", dependency.ItemSpec.Split ('/')) in the commercial <InstallAndroidDependencies/> task. That allowed the Downloading archive and Installing Android SDK component messages to appear as expected.

Version info

xamarin/android-sdk-installer@4ce982e5b50be23a7df2d3f244e325c2b82254c9

[brendanzagaeski]

Maybe a fix could be to adjust <CalculateProjectDependencies/> to use Path.Combine() in the following lines? https://github.com/xamarin/xamarin-android/blob/375e06236bc6947c69da92b0e45bb6f8dca94221/src/Xamarin.Android.Build.Tasks/Tasks/CalculateProjectDependencies.cs#L56-L57

[brendanzagaeski]

Release status update

I have locally verified that the non-public fix from https://github.com/xamarin/android-sdk-installer/commit/2b4d1a6a4c49c3bc3fc9751726d854d75c617434, included in 2cf80f5 resolves this issue.

A new Preview version of Xamarin.Android has now been published that includes the fix for this item. The fix is not yet included in a Release version. I will update this item again when a Release version is available that includes the fix.

Fix included in Xamarin.Android SDK version 11.1.0.15.

Fix included on Windows in Visual Studio 2019 version 16.8 Preview 4. To try the Preview version that includes the fix, check for the latest updates in Visual Studio Preview.

Fix included on macOS in Visual Studio 2019 for Mac version 8.8 Preview 4. To try the Preview version that includes the fix, check for the latest updates on the Preview updater channel.

[brendanzagaeski]

Release status update

A new Release version of Xamarin.Android has now been published that includes the fix for this item.

Fix included in Xamarin.Android SDK version 11.1.0.17.

Fix included on Windows in Visual Studio 2019 version 16.8. To get the new version that includes the fix, check for the latest updates or install the most recent release from https://visualstudio.microsoft.com/downloads/.

Fix included on macOS in Visual Studio 2019 for Mac version 8.8. To get the new version that includes the fix, check for the latest updates on the Stable updater channel.