[Xamarin.Android.Build.Tasks] _CreateAapt2VersionCache slow due to wildcard usage
#2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <_CompiledFlataStamp Include="$(IntermediateOutputPath)\**\compiled.stamp"/> | ||
| <_CompiledFlataArchive Include="$(IntermediateOutputPath)\lp\**\*.flata" Condition="'$(_Aapt2Version)' != '@(_Aapt2VersionCache)'" /> | ||
| <_CompiledFlataArchive Include="$(IntermediateOutputPath)\*.flata" Condition="'$(_Aapt2Version)' != '@(_Aapt2VersionCache)'" /> | ||
| <_CompiledFlataStamp Include="$(IntermediateOutputPath)\lp\**\compiled.stamp" Condition="'$(_Aapt2Version)' != '@(_Aapt2VersionCache)'" /> |
There was a problem hiding this comment.
Maybe all of these should use $(_AndroidLibrayProjectIntermediatePath)? (aaah typo)
Then these would still work if someone has $(UseShortFileNames)=False.
jonathanpeppers
approved these changes
Aug 31, 2018
dellis1972
force-pushed
the
Issue2121
branch
from
9ea53ec
to
215f26c
Compare
…wildcard usage Fixes dotnet#2121 There were a number of performace issues with `_CreateAapt2VersionCache`. First the wildcards were processing the ENTIRE `$(IntermediateOutputPath)`! What they should have been doing was targeting specific directories. I.e the root of `$(IntermediateOutputPath)` and the directories under `$(IntermediateOutputPath)\lp`. The target did not have a Condition to stop it running if the versions matched, so that has been added. However, even if a target is NOT run. MSbuild will still evaluate the `PropertyGroups` and `ItemGroups` within the targets. So we need to add `Conditon` on the `_CompiledFlataArchive` and `_CompiledFlataStamp` items as well. With these in place the time when this target is skipped is down to 1ms.
dellis1972
force-pushed
the
Issue2121
branch
from
215f26c
to
e66c879
Compare
|
@jonpryor this should be good ,the failing test is
which is not related to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121
There were a number of performace issues with
_CreateAapt2VersionCache.First the wildcards were processing the ENTIRE
$(IntermediateOutputPath)!What they should have been doing was targeting specific
directories. I.e the root of
$(IntermediateOutputPath)andthe directories under
$(IntermediateOutputPath)\lp.Second the target did not have a Condition to stop it running if
the versions matched, so that has been added.
However, even if a target is NOT run. MSbuild will still evaluate
the
PropertyGroupsandItemGroupswithin the targets. So weneed to add
Conditonon the_CompiledFlataArchiveand_CompiledFlataStampitems as well.With these in place the time when this target is skipped is down
to 1ms.