[ResolveSdksTask] cache JdkJvmPath value #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements dotnet#2374 As the `ResolveSdks` task is used in every build, try to make it faster. I tried to measure few builds and the time went from ~540ms to ~240ms per 3 calls. (there were also some longer builds with cached value as well. I think it is just a fluctuation I see on my old notebook)
radekdoulik
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
reviewed
Nov 5, 2018
jonathanpeppers
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2374
As the
ResolveSdkstask is used in every build, try to make it faster.I tried to measure few builds and the time went from ~540ms to ~240ms
per 3 calls. (there were also some longer builds with cached value as
well. I think it is just a fluctuation I see on my old notebook)