Deploy target #2905
Deploy target #2905
Conversation
There was a problem hiding this comment.
@xtmq is this the actual error message you get from the IDE? Can you paste what you get in the error pad?
I'm asking because that code is in the proprietary part of Xamarin.Android. It would be Xamarin.Android.Common.Debugging.targets, an MSBuild task called <InstallPackageAssemblies/>.
|
I use Xamarin Android SDK built from sources so I have no |
|
Or are you going to open source these targets? I have not read about that.... |
|
No, I just wanted to make sure we didn’t have something else to fix, thanks. |
|
No, deploy in VS SDK works much better then the default one... |
|
@monojenkins build |
|
What does it look like within the IDE? Behold, a test app! Scratch.IdeErrorMessageDisplay.zip
Open Visual Studio for Mac ResultsCreateErrorsOriginal results in a single error message, with all output on a single line: I personally don't like it. CreateErrorsItemGroupMultiLine results in three separate error messages, a "summary" line and then the two lines of output from the failing command: CreateErrorsItemGroupSingleLine results in a single error message, but -- unexpectedly! -- has a disclosure triangle. When it's first shown, only the first line of output is displayed: Expand the disclosure triangle, and all the lines are shown: This is my favorite rendition on macOS. I need to try Windows. |
|
What about Windows & Visual Studio 2017? CreateErrorsOriginal: CreateErrorsItemGroupMultiLine: CreateErrorsItemGroupSingleLine: |
|
Note: In order to get things to fail on Windows, I had to change <_Command>echo 'this is line 1' & echo 'line 2' & exit 1</_Command>Overall, on Windows I think CreateErrorsItemGroupSingleLine is the only good one. CreateErrorsItemGroupMultiLine has some weird ordering, and CreateErrorsOriginal will become unreadable as output length increases. |
|
|
|
@monojenkins build |
|
Thanks, your version indeed looks better =) |
Context: b002dc3 Context: #2905 (comment) If an error occurs when compiling or linking native assembler files generated by .NET Android, we log an error which doesn't contain any useful information: error XA3006: Could not compile native assembly file: compressed_assemblies.x86.ll The real cause of the issue is logged as well, but not as an error; it's visible in the Diagnostic log as a "plain" message, which is not immediately accessible to the user experiencing the issue. Keep logging the output messages of the assembler and linker programs as before, but whenever an error occurs, log their entire output (stdout and stderr) as a single MSBuild message with newlines between each each line of stdout/stderr. This will render within Visual Studio as a multi-line error message ("CreateErrorsItemGroupSingleLine" in #2905).
Context: b002dc3 Context: #2905 (comment) If an error occurs when compiling or linking native assembler files generated by .NET Android, we log an error which doesn't contain any useful information: error XA3006: Could not compile native assembly file: compressed_assemblies.x86.ll The real cause of the issue is logged as well, but not as an error; it's visible in the Diagnostic log as a "plain" message, which is not immediately accessible to the user experiencing the issue. Keep logging the output messages of the assembler and linker programs as before, but whenever an error occurs, log their entire output (stdout and stderr) as a single MSBuild message with newlines between each each line of stdout/stderr. This will render within Visual Studio as a multi-line error message ("CreateErrorsItemGroupSingleLine" in #2905).
When adb fails it is difficult to understand thats going on especially from IDE where an user usually observes only error messages, something like:
It is better to have an error message like