[build] Make MinGW build on mac generate less noise #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the Windows cross-build on macOS using MinGW leaves behind a lot of temporary LTO (Link-Time Optimization) files, the result of passing the `-flto` flag to the compilers. The temporary files (`*.ltrans*`), around 280 of them, are then included in our vsix packages, increasing their size while being completely useless for the end user. This commit fixes the issue by turning off LTO for MinGW targets. The optimization is not really useful there and such fix is faster than tracking why MinGW on macOS (installed from Homebrew) is behaving the way it is.
grendello
force-pushed
the
build/lto-off-mingw
branch
from
50c91db
to
17bd593
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 11, 2019
|
Kicked off PR #2962 so we can see what the resulting |
jonpryor
pushed a commit
that referenced
this pull request
Apr 11, 2019
For some reason the Windows mingw cross-build on macOS using MinGW leaves behind a lot of temporary LTO (Link-Time Optimization) files, the result of passing the `-flto` flag to the compilers. The temporary files (`*.ltrans*`), around 280 of them, are then included in our d16-1 `.vsix` packages, increasing their size while being completely useless for the end user. This commit fixes the issue by turning off LTO for MinGW targets. The optimization is not really useful there and such fix is faster than tracking why MinGW on macOS (installed from Homebrew) is behaving the way it is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the Windows cross-build on macOS using MinGW leaves behind a lot
of temporary LTO (Link-Time Optimization) files, the result of passing the
-fltoflag to the compilers. The temporary files (*.ltrans*), around 280 ofthem, are then included in our vsix packages, increasing their size while being
completely useless for the end user.
This commit fixes the issue by turning off LTO for MinGW targets. The
optimization is not really useful there and such fix is faster than tracking why
MinGW on macOS (installed from Homebrew) is behaving the way it is.