[Tuner] Don't generate AbstractMethodErrors for default interface methods #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
requested review from
dellis1972,
jonathanpeppers and
radekdoulik
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #1939.
Today when we are compiling a class deriving from
Java.Lang.Objectthat implements an interface and we see a method that exists on the interface that isn't implemented on the class we inject an override method that throws anAbstractMethodErrorexception.With Default Interface Members, we need to ignore members that are implemented on the interface and not generate an override. This is done by restricting our generation to
abstractmethods.Original context here: f96fcf9