[test] add an assertion checking Debug startup time #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
debugger-perf-timeout
branch
4 times, most recently
from
2c546c5
to
fb8d05a
Compare
In a26e0db and 5bfe44e we found a performance regression with startup in Debug builds. To better catch this in the future, I updated `DebuggingTest`. If it takes longer than 1 second for the debugger to connect, the test will fail now. This worked on my PC with a HAXM emulator, we will see if this number is too optimistic for our CI servers.
jonathanpeppers
force-pushed
the
debugger-perf-timeout
branch
from
fb8d05a
to
a31d4af
Compare
jonathanpeppers
requested review from
dellis1972 and
jonpryor
as code owners
dellis1972
approved these changes
Dec 10, 2019
pjcollins
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a26e0db and 5bfe44e we found a performance regression with
startup in Debug builds.
To better catch this in the future, I updated
DebuggingTest.If it takes longer than 1 second for the app to start and debugger
connect, the test will fail now.
This worked on my PC with a HAXM emulator, we will see if this number
is too optimistic for our CI servers.