[Xamarin.Andrdoid.Build.Tasks] Add XA1010 code for invalid placeholders #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#1560 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Add a warning code XA1010 to the existing warning about invalid values of `$(AndroidManifestPlaceholders)`, and move the message string into the `.resx` file so that it is localizable. Other changes: Correct the warning to say `AndroidManifestPlaceholders` instead of `AndroidApplicationPlaceholders`. Correct the warning to show the list of key-value pairs from the property instead of `System.String[]`. Add an entry for `$(AndroidManifestPlaceholders)` in `BuildProcess.md`.
brendanzagaeski
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
dellis1972
approved these changes
Mar 12, 2020
jonathanpeppers
approved these changes
Mar 12, 2020
jonpryor
pushed a commit
that referenced
this pull request
Mar 15, 2020
…rs (#4387) Context: #1560 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Add a warning code XA1010 to the existing warning about invalid values of `$(AndroidManifestPlaceholders)`, and move the message string into the `.resx` file so that it is localizable. Other changes: Correct the warning to say `AndroidManifestPlaceholders` instead of `AndroidApplicationPlaceholders`. Correct the warning to show the list of key-value pairs from the property instead of `System.String[]`. Add an entry for `$(AndroidManifestPlaceholders)` in `BuildProcess.md`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1560
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/
Add a warning code XA1010 to the existing warning about invalid values
of
$(AndroidManifestPlaceholders), and move the message string intothe
.resxfile so that it is localizable.Other changes:
Correct the warning to say
AndroidManifestPlaceholdersinstead ofAndroidApplicationPlaceholders.Correct the warning to show the list of key-value pairs from the
property instead of
System.String[].Add an entry for
$(AndroidManifestPlaceholders)inBuildProcess.md.