Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debugger] Trying to fix debug 2 assemblies with similar names #7113

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jun 20, 2022

First assembly loaded is named: chromebookdebuggerissue.Android.dll
And the second one is named: chromebookdebuggerissue.dll

if (strncmp ("chromebookdebuggerissue.Android", "chromebookdebuggerissue", (long unsigned int) 23) != 0)
    printf("skipping\n");
else
    printf("using\n");

It does this comparison and then uses the PDB of chromebookdebuggerissue.Android.dll as symbol of chromebookdebuggerissue.dll.

Fixes #7089

@thaystg
Copy link
Member Author

thaystg commented Jun 20, 2022

@grendello is there a way to download xamarin-android installer to test if it's working? I would like to test on windows before merge.

@grendello
Copy link
Contributor

@grendello is there a way to download xamarin-android installer to test if it's working? I would like to test on windows before merge.

If you go to the pipeline that builds this PR, you can find the installers in the published artifacts, in the installers-unsigned folder

@thaystg
Copy link
Member Author

thaystg commented Jun 21, 2022

I think it's working, can I merge? or this red's on CI are blocker?

@grendello
Copy link
Contributor

I think it's working, can I merge? or this red's on CI are blocker?

I restarted the failed tests, let's wait for them to run again.

@grendello grendello merged commit 40930d0 into dotnet:main Jun 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger not working in cross platform project when running on chrome os (chromebook)
2 participants