New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild] Only execute DetectDebugNetworkConfigurationTask for debug builds #10194
Merged
spouliot
merged 1 commit into
xamarin:main
from
spouliot:msbuild-detect-debug-net-config-on-debug-only
Dec 4, 2020
Merged
[msbuild] Only execute DetectDebugNetworkConfigurationTask for debug builds #10194
spouliot
merged 1 commit into
xamarin:main
from
spouliot:msbuild-detect-debug-net-config-on-debug-only
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builds Not that it was very slow but it did make to the top 10 of the archive build I was debugging. Also reduce allocations in the task itself, for when it's needed.
mandel-macaque
approved these changes
Dec 2, 2020
tj-devel709
approved these changes
Dec 3, 2020
dalexsoto
approved these changes
Dec 3, 2020
rolfbjarne
approved these changes
Dec 3, 2020
Build failure Test results67 tests failed, 26 tests passed.Failed tests
|
build |
Build success |
emaf
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that it was very slow but it did make to the top 10 of the
archive build I was debugging.
Also reduce allocations in the task itself, for when it's needed.