Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Archive the user frameworks .dSYM when available #10220

Merged
merged 1 commit into from Dec 9, 2020

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Dec 4, 2020

This also includes dSYM inside xcframeworks, e.g.

...
├── dSYMs
│   ├── Universal.framework.dSYM
│   │   └── Contents
│   │       ├── Info.plist
│   │       └── Resources
│   │           └── DWARF
│   │               └── Universal
│   └── xcf_ios.app.dSYM
│       └── Contents
│           ├── Info.plist
│           └── Resources
│               └── DWARF
│                   └── xcf_ios
...

from https://github.com/spouliot/xcframework/tree/main/xamarin/xcf-ios

versus

...
└── dSYMs
    ├── Universal.framework.dSYM
    │   └── Contents
    │       ├── Info.plist
    │       └── Resources
    │           └── DWARF
    │               └── Universal
    └── xcf-ios.app.dSYM
        └── Contents
            ├── Info.plist
            └── Resources
                └── DWARF
                    └── xcf-ios
...

from the similar ObjC sample https://github.com/spouliot/xcframework/tree/main/objc/xcf-ios

This also includes dSYM inside xcframeworks, e.g.

```
...
├── dSYMs
│   ├── Universal.framework.dSYM
│   │   └── Contents
│   │       ├── Info.plist
│   │       └── Resources
│   │           └── DWARF
│   │               └── Universal
│   └── xcf_ios.app.dSYM
│       └── Contents
│           ├── Info.plist
│           └── Resources
│               └── DWARF
│                   └── xcf_ios
...
```
from https://github.com/spouliot/xcframework/tree/main/xamarin/xcf-ios

versus
```
...
└── dSYMs
    ├── Universal.framework.dSYM
    │   └── Contents
    │       ├── Info.plist
    │       └── Resources
    │           └── DWARF
    │               └── Universal
    └── xcf-ios.app.dSYM
        └── Contents
            ├── Info.plist
            └── Resources
                └── DWARF
                    └── xcf-ios
...
```
from the similar ObjC sample https://github.com/spouliot/xcframework/tree/main/objc/xcf-ios
@spouliot spouliot added the enhancement The issue or pull request is an enhancement label Dec 4, 2020
@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Failed to build src/
    Search for Comparing API & creating generator diff in the log to view the complete log.
Test run succeeded

@spouliot
Copy link
Contributor Author

spouliot commented Dec 7, 2020

Failure is unrelated -> #10222

@spouliot spouliot merged commit 9a7e206 into xamarin:main Dec 9, 2020
@spouliot spouliot deleted the archive-framework-dsym branch December 9, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants