Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[corebluetooth] Add nullability to (generated and manual) bindings #10241

Merged
merged 1 commit into from Dec 9, 2020
Merged

[corebluetooth] Add nullability to (generated and manual) bindings #10241

merged 1 commit into from Dec 9, 2020

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Dec 9, 2020

See HOWTO

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

🔥 Provisioning failed 🔥

@spouliot spouliot added the enhancement The issue or pull request is an enhancement label Dec 9, 2020
@spouliot
Copy link
Contributor Author

spouliot commented Dec 9, 2020

build

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

🔥 Provisioning failed 🔥

@rolfbjarne
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Failed to build src/
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

1 tests failed, 76 tests passed.

Failed tests

  • link all/tvOS - simulator/Debug: Failed

@spouliot
Copy link
Contributor Author

spouliot commented Dec 9, 2020

Failure is a known random network issue -> https://github.com/xamarin/maccore/issues/1083

@spouliot spouliot merged commit aa73c33 into xamarin:main Dec 9, 2020
@spouliot spouliot deleted the corebluetooth-nullability branch December 9, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spouliot @monojenkins @rolfbjarne @dalexsoto