Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spritekit] Add nullability to (generated and manual) bindings #10262

Merged
merged 2 commits into from Dec 14, 2020

Conversation

spouliot
Copy link
Contributor

See HOWTO

@spouliot spouliot added the enhancement The issue or pull request is an enhancement label Dec 11, 2020
@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

Provisioning succeeded
🔥 Build failed 🔥

@spouliot
Copy link
Contributor Author

20:31:23 make[2]: *** [downloads/maccat-release-Darwin-dfbfe5eed1992905b0dac80a8dc7d6f1f9647735.7z] Error 92
20:31:23 make[1]: *** [.stamp-download-mono] Error 2

file seems to exists ?!?

@spouliot
Copy link
Contributor Author

build

@dalexsoto
Copy link
Member

What's up with you and the bots @spouliot ?

@spouliot
Copy link
Contributor Author

@dalexsoto it's reciprocal 🤖 😒

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

11 tests failed, 66 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: Failed (Tests run: 2177 Passed: 2042 Inconclusive: 7 Failed: 4 Ignored: 131)
  • xammac tests/Mac Modern/Release: Failed (Tests run: 2177 Passed: 2042 Inconclusive: 7 Failed: 4 Ignored: 131)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Tests run: 1832 Passed: 1739 Inconclusive: 4 Failed: 4 Ignored: 89)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Debug: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed

@monojenkins
Copy link
Collaborator

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@spouliot spouliot merged commit 50e91de into xamarin:main Dec 14, 2020
@spouliot spouliot deleted the spritekit-nullability branch December 14, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants