Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate assembly names passed in the MtouchInterpreter msbuild property #20302

Open
simonrozsival opened this issue Mar 13, 2024 · 0 comments
Open
Labels
enhancement The issue or pull request is an enhancement
Projects
Milestone

Comments

@simonrozsival
Copy link
Contributor

There are no build warnings or build errors when the assembly names in the $(MtouchInterpreter) property are in the wrong format or if there is no such assembly in the project. It is hard for the developer to diagnose the problem. Customers are likely to run into this issue because of a bug in the docs which suggest listing assemblies with the .dll extension when Xamarin compares comma separated items in the property with the assembly file names without an extension.

Steps to Reproduce

  1. Create a new iOS app with dotnet new ios -o TestMtouchInterpreter
  2. Add <MtouchInterpreter>-all,TestMtouchInterpreter.dll</MtouchInterpreter> based on the documentation (https://learn.microsoft.com/en-us/dotnet/maui/macios/interpreter?view=net-maui-8.0, see Fix mono interpreter examples dotnet/docs-maui#2141)
  3. Build the app in Release mode

Expected Behavior

The TestMtouchInterpreter.dll assembly is not AOTed and instead it is interpreted.

Actual Behavior

The TestMtouchInterpreter.dll assembly is AOTed and not interpreted.

Other examples of invalid inputs

<MtouchInterpreter>-all,+TestMtouchInterpreter.dll</MtouchInterpreter>
@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label Mar 13, 2024
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Mar 13, 2024
@rolfbjarne rolfbjarne added this to Other in .NET 9 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue or pull request is an enhancement
Projects
.NET 9
Other
Development

No branches or pull requests

2 participants