Migrate Messaging Build agent to .NET 8 #20705

emaf · 2024-06-07T21:37:33Z

This is part of the effort to migrate the Pair to Mac agents .NET.

As the Xamarin.iOS.Tasks.Windows project targets netstandard2.0, I'm removing the Build agent reference, and modifying the Makefile to take it from it's output directory. Note: the agent zip file is generated in the intermediate output directory.

This is part of the effort to migrate the Pair to Mac agents .NET. As the Xamarin.iOS.Tasks.Windows project targets netstandard2.0, I'm removing the Build agent reference, and modifying the Makefile to take it from it's output directory. Note: the agent zip file is generated in the intermediate output directory.

github-actions · 2024-06-07T21:41:02Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

emaf · 2024-06-13T15:35:06Z

/sudo backport release/8.0.1xx-xcode15.1

vs-mobiletools-engineering-service2 · 2024-06-13T15:35:45Z

Backport Job to branch release/8.0.1xx-xcode15.1 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-06-13T15:39:01Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9722999 for more details.

rolfbjarne

The tests are passing now! However, it looks like you're bumping Xamarin.MacDev to an earlier commit, maybe by mistake?

emaf · 2024-06-21T19:05:24Z

The tests are passing now! However, it looks like you're bumping Xamarin.MacDev to an earlier commit, maybe by mistake?

I think it came into this branch from this merge from main: 7910b52. Not sure why though.

I'll revert that.

vs-mobiletools-engineering-service2 · 2024-06-21T21:03:40Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:03:58Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:05:22Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:05:50Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:08:02Z

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:25:29Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:39:44Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-21T21:55:24Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-24T10:14:57Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-24T10:55:24Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

vs-mobiletools-engineering-service2 · 2024-06-24T12:05:04Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 89561387a1aee0d0260319a05273afae04fd40b2 [PR build]

This reverts commit f8552e9. This change is only supposed to be released with .NET 9, and we might release new .NET 8 updates from main. Thus we need to make sure these changes are only in the net9.0 branch (they already are).

emaf added 2 commits June 7, 2024 17:35

Bump Messaging to a test version

4715307

emaf requested review from rolfbjarne and mauroa as code owners June 7, 2024 21:37

emaf added the do-not-merge Do not merge this pull request label Jun 7, 2024

Auto-format source code

ce4e298

This comment has been minimized.

Sign in to view

mauroa approved these changes Jun 10, 2024

View reviewed changes

Bump Messaging to 2.0.13

5ea6979

emaf changed the title ~~[WIP] Migrate Messaging Build agent to .NET 8~~ Migrate Messaging Build agent to .NET 8 Jun 12, 2024

emaf removed the do-not-merge Do not merge this pull request label Jun 12, 2024

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Jun 12, 2024

View reviewed changes

Merge branch 'main' into dev/ema/messaging-net8

7910b52

emaf mentioned this pull request Jun 13, 2024

[release/8.0.1xx-xcode15.1] Migrate Messaging Build agent to .NET 8 #20727

Closed

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Jun 21, 2024

View reviewed changes

Revert Xamarin.MacDev to 4cb9dc2

8956138

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Jun 24, 2024

View reviewed changes

rolfbjarne merged commit f8552e9 into main Jun 24, 2024
27 checks passed

rolfbjarne mentioned this pull request Jun 24, 2024

[net9.0] Migrate Messaging Build agent to .NET 8 #20775

Closed

dalexsoto deleted the dev/ema/messaging-net8 branch June 28, 2024 16:12

Migrate Messaging Build agent to .NET 8 #20705

Migrate Messaging Build agent to .NET 8 #20705

Conversation

emaf commented Jun 7, 2024

github-actions bot commented Jun 7, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

emaf commented Jun 13, 2024

vs-mobiletools-engineering-service2 commented Jun 13, 2024

vs-mobiletools-engineering-service2 commented Jun 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

emaf commented Jun 21, 2024

vs-mobiletools-engineering-service2 commented Jun 21, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jun 21, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jun 21, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented Jun 21, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jun 21, 2024

📚 [CI Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jun 21, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Jun 21, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jun 21, 2024

❌ [CI Build] Windows Integration Tests failed ❌

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 24, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Jun 24, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jun 24, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts