[appkit] Make NSCell and NSControl 'Formatter' accept null #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes xamarin#6032: NSTextField.Formatter missing null-allowed (xamarin#6032)
rolfbjarne
approved these changes
May 10, 2019
chamons
approved these changes
May 10, 2019
|
Build success |
spouliot
approved these changes
May 10, 2019
| @@ -4795,7 +4795,7 @@ partial interface NSControl { | |||
| [Export ("font")] | |||
| NSFont Font { get; set; } | |||
|
|
|||
| [Export ("formatter", ArgumentSemantic.Retain)] | |||
| [Export ("formatter", ArgumentSemantic.Retain), NullAllowed] | |||
| NSObject Formatter { get; set; } | |||
There was a problem hiding this comment.
According to the latest doc (did not check headers) it's an NSFormatter or a subclass (__kindof) so, to avoid forgetting it, maybe
#if XAMCORE_4_0
NSFormatter Formatter { get; set; }
#else
NSObject Formatter { get; set; }
#endif
|
Build failure Test results1 tests failed, 0 tests skipped, 98 tests passed.Failed tests
|
|
Known issue: https://github.com/xamarin/maccore/issues/1595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NSTextField.Formatter missing null-allowed #6032)