Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate NullAllowed for ToolTip properties in AppKit #6119

Merged
merged 1 commit into from Jun 12, 2019
Merged

Annotate NullAllowed for ToolTip properties in AppKit #6119

merged 1 commit into from Jun 12, 2019

Conversation

Therzok
Copy link
Contributor

@Therzok Therzok commented May 23, 2019

I'm not sure whether [return: NullAllowed] should also be applied to properties for the getters.

Actual fix for #6108

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@chamons
Copy link
Contributor

chamons commented May 24, 2019

build

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@Therzok Therzok mentioned this pull request Jun 12, 2019
Closed
@Therzok
Copy link
Contributor Author

Therzok commented Jun 12, 2019

Anything holding this up?

@chamons
Copy link
Contributor

chamons commented Jun 12, 2019

You hitting the button :)

I'll slap merge.

@chamons chamons merged commit 253170d into master Jun 12, 2019
@chamons chamons deleted the Therzok-patch-3 branch June 12, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@chamons chamons chamons approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Therzok @monojenkins @chamons @rolfbjarne @xamarin-release-manager