Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coregraphics] Update for Xcode 11 beta 1 and 2 #6337

Merged
merged 5 commits into from
Jun 19, 2019
Merged

[coregraphics] Update for Xcode 11 beta 1 and 2 #6337

merged 5 commits into from
Jun 19, 2019

Conversation

spouliot
Copy link
Contributor

along with unit tests for p/invokes

[coregraphics] Update for Xcode 11 beta 1
d453f6b 
along with unit tests for p/invokes
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 84 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

rolfbjarne
rolfbjarne approved these changes Jun 17, 2019
View reviewed changes
src/CoreGraphics/CGColorConversionInfo.cs Outdated
[iOS (13,0)]
[TV (13,0)]
[Watch (6,0)]
public CGColorConversionInfo (CGColorSpace src, CGColorSpace dst, NSDictionary options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: parameter names should not be abbreviated (src -> source, dst -> destination).

src/CoreGraphics/CGColorConversionInfo.cs Outdated
[iOS (13,0)]
[TV (13,0)]
[Watch (6,0)]
public CGColorConversionInfo (CGColorSpace src, CGColorSpace dst, CGColorConversionOptions options) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same: parameter names.

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

7 tests failed, 84 tests passed.

Failed tests

  • xammac tests/Mac Unified/Debug: Failed (Test run crashed (exit code: 134).)
  • xammac tests/Mac Unified/Release (all optimizations): Failed (Test run crashed (exit code: 134).)
  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliot spouliot added the do-not-merge Do not merge this pull request label Jun 17, 2019
@spouliot
Copy link
Contributor Author

I'll update it for beta2 before merging it

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 88 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Jun 18, 2019
@spouliot spouliot changed the title [coregraphics] Update for Xcode 11 beta 1 [coregraphics] Update for Xcode 11 beta 1 and 2 Jun 18, 2019
@spouliot spouliot added this to the xcode11 milestone Jun 18, 2019
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 88 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliot
Copy link
Contributor Author

known issues

@spouliot spouliot merged commit fee66b3 into xamarin:xcode11 Jun 19, 2019
@spouliot spouliot deleted the xcode11-coregraphics-b1 branch June 19, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
xcode11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spouliot @monojenkins @dalexsoto @rolfbjarne @whitneyschmidt