[coreanimation] Update for Xcode 11 beta 1 and 2 #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no change in watchOS SDK headers... but they are marked as available (to watchOS) inside iOS, tvOS and macOS. Not a new situation and IIRC we reported it before (will check and report again if needed)
|
Build success |
dalexsoto
approved these changes
Jun 21, 2019
src/coreanimation.cs
Outdated
| [EditorBrowsable (EditorBrowsableState.Advanced)] | ||
| [Static] | ||
| [Export ("cornerCurveExpansionFactor:")] | ||
| nfloat GetCornerCurveExpansionFactor (NSString curve); |
There was a problem hiding this comment.
Why not nfloat GetCornerCurveExpansionFactor ([BindAs (typeof (CACornerCurve))] NSString curve); instead of the manual wrap? Since you are already doing it for the property.
There was a problem hiding this comment.
I forgot about it - and updated the others afterward (and missed that one) :D
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no change in watchOS SDK headers... but they are marked as
available (to watchOS) inside iOS, tvOS and macOS. Not a new situation
and IIRC we reported it before (will check and report again if needed)