Rename bundle identifier for the frameworks we ship. Fixes #6920. #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the bundle identifier for the frameworks we ship, because apparently Apple has added an App Store check to reject apps with multiple frameworks with the same bundle identifier. For some reason that includes rejecting frameworks that are both in iOS and watchOS apps. This feels like a bug on Apple's end, but we can still easily work around it, so let's do just that. Strictly speaking it's not necessary to change the bundle identifier for tvOS frameworks, but it's more consistent that way. Fixes xamarin#6920.
rolfbjarne
added
bug
dalexsoto
approved these changes
Sep 6, 2019
spouliot
approved these changes
Sep 6, 2019
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the bundle identifier for the frameworks we ship, because apparently
Apple has added an App Store check to reject apps with multiple frameworks
with the same bundle identifier.
For some reason that includes rejecting frameworks that are both in iOS and
watchOS apps. This feels like a bug on Apple's end, but we can still easily
work around it, so let's do just that.
Strictly speaking it's not necessary to change the bundle identifier for tvOS
frameworks, but it's more consistent that way.
Fixes #6920.