[mtouch] Auto-change settings where they're honored for extensions. Fixes #7780. #7786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes xamarin#7780. When building extensions, we first store all the mtouch arguments in a file when msbuild builds the extension, and then when msbuild builds the main project, we load those arguments again and actually build the extension at the same time as we build the main app. As such, it's important to make sure that when we reload the extension arguments we end up with the exact same build configuration as the first time. Unfortunately that was not the case regarding the interpreter: we automatically set the 'EnableRepl' value in Main according to whether the interpreter was enabled or not, but Main is not called after re-loading the arguments when building extensions. Fix this by moving the logic that automatically sets 'EnableRepl' to somewhere that is executed when re-loading arguments when building extensions. Fixes xamarin#7780.
dalexsoto
approved these changes
Feb 3, 2020
spouliot
approved these changes
Feb 3, 2020
mandel-macaque
approved these changes
Feb 3, 2020
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
|
Test failure is unrelated: https://github.com/xamarin/maccore/issues/581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building extensions, we first store all the mtouch arguments in a file
when msbuild builds the extension, and then when msbuild builds the main
project, we load those arguments again and actually build the extension at the
same time as we build the main app.
As such, it's important to make sure that when we reload the extension
arguments we end up with the exact same build configuration as the first time.
Unfortunately that was not the case regarding the interpreter: we
automatically set the 'EnableRepl' value in Main according to whether the
interpreter was enabled or not, but Main is not called after re-loading the
arguments when building extensions.
Fix this by moving the logic that automatically sets 'EnableRepl' to somewhere
that is executed when re-loading arguments when building extensions.
Fixes #7780.