Add missing ctors to AVPlayerItemMetadataCollector and SKCloudServiceController #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chamons
commented
Apr 15, 2020
•
chamons
commented
- AVPlayerItemMetadataCollector and SKCloudServiceController have DisableDefaultCtor incorrectly #8398
- They were incorrectly marked DisableDefaultCtor in an attempt to fix API breaks
- Manual tests/documentation shows that the default init works
…Controller - xamarin#8398 - They were incorrectly marked DisableDefaultCtor in an attempt to fix API breaks - Manual tests/documentation shows that the default init works
chamons
changed the title
spouliot
approved these changes
Apr 15, 2020
mandel-macaque
approved these changes
Apr 15, 2020
|
Build success |
rolfbjarne
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.